Conversation
Member
|
oops, sorry, I did a squash merge without thinking in #105, which lost the shared history with this PR and now there's a conflict that needs resolved. |
Member
|
LGTM! This now gives us full coverage of the same wheels that NumPy provides except for win32, which I think is the best we can hope for. |
Collaborator
Author
Yes. The SciPy folks are looking for excuses to drop wheels for 32-bit platforms, though I imagine numpy will keep them longer than scipy will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #105. This PR adds one commit on top of that PR.
Add musllinux wheels.
Using separate runner mostly for speed. The musl build ends up compiling numpy from source for most Python versions because
oldest-supported-numpydoes not discriminate by libc version and installs a version older than 1.25 (the first numpy with musl wheels). The separate runner also enables libgraphblas to be built against Musl and not glibc.