Update detection for Performance Lab WordPress plugin #22
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rviscomi @tunetheweb Could you please review when you get a chance? It would be great if this could be part of the next pipeline run already later in April, to avoid a disruption in the detection of the Performance Lab plugin. |
westonruter
approved these changes
Apr 4, 2024
rviscomi
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WordPress/performance#1103 (specifically here) the
meta[name="generator"]tag of the Performance Lab plugin was changed to use another format, which will be rolled out with the 3.0.0 release on April 15.In order to continue to correctly detect usage of the plugin, this PR updates the Wappalyzer detection, to support both the old and new format.