Very well. The logic is correct but you can also reduce it in a single statement using a programming practice called method chaining. For example,

const str = 'dlroW olleH';
const reversedString = str.split('').reverse().join('');

Here I have merged all three operations in a single statement using method chaining.

Oh! It's a very great way! Thank you to show me.

Wondering why did you have to repeat this homework submission here? I remember that you were unable to make it to the Week1 where we covered Gitflow in a bit more detail. Let me or Tjebbe know please if you have any confusions or questions around working with Git and we can perhaps work on something. 🙂

Yes, I did it accidentally then I figured out how to correctly use all this git system.

👍 for logic. I would also like to introduce a new feature in JavaScript ES6 called template literals. It can be found here - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Using template literals allows you to combine variables and strings and avoid using + operator to concatenate strings.

`corrected string is: ${myString.replace(/,/g, ' '});`

I already start to use them. And I love it!

This again? 🤔

Very nice of you to create a function for this purpose. 👏

However, there is a slight indentation problem on line 3. 🙂

extra tab?

👍

A very small thing to improve is space between words like - x = 13;

I got it.

Same comment as above about spacing 🙂

yep

A couple things to improve here:

1. You didn't declare variable fin anywhere in this file. This means JavaScript will create fin as a global variable which is not nice 😱
2. Indentation problem here. Better if it is like this:

if (z < a) {
  fin = a;
} else {
  fin = z;
}

Err! animals is an empty array here.

I thought it's a part of the task.

👍

Two things here:

1. You didn't use any keyword like var, let or const while creating these variables. It's a bad practice to do so. Please take care next time onwards. 🙂
2. Types of variables x and c would the same i.e number 😉

1. I was so young and green.
2. So it was conceived.

Hmm.. I wonder why there is indentation problem when you are using if-else blocks. 🤔

Also, make sure you include spaces which makes code more readable. Something like:

(typeof x === typeof y)

ok

Only missing thing here is using var, let or const to create variables.

Just FYI - if you are not going to reassign a variable later in the code(x in this case), it's generally a good practice to use const instead of let or var. 🙂

I got it. Thanks.

👍

You can also use favoriteAnimals.push('turtle'); instead.

ok

👍

You can also use const here instead of let.

ok

Aahaan. This isn't the best way of dealing this situation. When we write functions in JavaScript, we should try to use only function parameters or local function variables instead of relying on variables outside the function's scope. Thus, using x here isn't ideal as it belongs outside the function's scope. A better way to do this would be:

function abcSum(a,b,c) {
    const x = a + b + c;
    return x;
};
console.log(abcSum(1,2,3));

Now I understand. Thank you.

👍

const here instead of let 🙂

ok

Hmm.. I think a better way to do this would be like this:

function showPropValue(obj) {
  for (const prop in obj) {
    console.log(obj[prop]);
  }
}

showPropValue(person);

What do you think? Can you see some advantages of writing a function like this?

Well, I think I wrote pretty the same function. The only difference is that my function shows not only values but names of properties also. As it was asked in a task.

👍