Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

homework week1 Muhammad Hussein#176

Closed
MA-Hussein wants to merge 10 commits intoHackYourFuture:masterfrom
MA-Hussein:week-1-homework-Muhammad_Hussein
Closed

homework week1 Muhammad Hussein#176
MA-Hussein wants to merge 10 commits intoHackYourFuture:masterfrom
MA-Hussein:week-1-homework-Muhammad_Hussein

Conversation

@MA-Hussein
Copy link

No description provided.

Copy link
Contributor

@yash-kapila yash-kapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MA-Hussein - I've finished reviewing your homework and am happy to approve it. I've added a few comments though which I think would help you. Could you please have a look at them? Good luck!

console.log("Hei Verden");
console.log("Dia duit ar domhan");
console.log("Hallo wr�ld");
console.log("Bonjou mond lan"); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

console.log("They are the same!");
}else {
console.log("Two different sizes");
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

"use strict";
/* console.log('I'm awesome'); will not work because we need to escape the single quotation
mark we need to use \ character. */
console.log('I\'m awesome'); //will work fine. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

console.log(myString);
myString = "Muhammad"
console.log("my first name will be the result.");
console.log(myString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

newVariable = a;
};

console.log(newVariable); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but you could also explore using conditional operators for assigning value to newVariable as this is a good case of using them

let favoriteAnimals = ["Hamsters", "Cats", "Dogs",];
console.log(favoriteAnimals);
favoriteAnimals.push("Horses");
console.log(favoriteAnimals); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use const instead of let here 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


"use strict";
let mySentence = "Programming is so interesting!";
console.log(mySentence.length); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const instead of let here as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

let var4 = {itemName:"laptop",itemId:0200};


console.log(typeof var1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for implementation but you could use const instead of let here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


console.log(y); /* We can see they still have their initial values.
Because the remainder includes x but not y and z.*/
console.log(z); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄. There was an error in the homework which David corrected this morning. Would you like to revisit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated according to the homework updates . Thanks a lot Ysah for your helpful comments .

@yash-kapila yash-kapila self-assigned this Sep 24, 2019
@wouterkleijn
Copy link
Contributor

Thanks for the changes @MA-Hussein ! Is this approved now @yash-kapila ?

@yash-kapila
Copy link
Contributor

Yip. This is approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants