This repository was archived by the owner on May 14, 2024. It is now read-only.
Closed
Conversation
remarcmij
suggested changes
Jan 24, 2019
Collaborator
remarcmij
left a comment
There was a problem hiding this comment.
Hi @Aya92syr, there are too many issues with this pull request to even consider reviewing it in detail. To name the most important ones:
- You have worked on the
masterbranch. - There are 88 ESLint errors, most of them because your VSCode configuration is still not correct.
- The PR contains both week1 and week2 homework.
- You have used the
varkeyword throughout, where we have stressed time and again to useletandconst. - It fails the unit tests for week2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.