This repository was archived by the owner on May 14, 2024. It is now read-only.
corrected version homework week1#266
Closed
alquinex wants to merge 2 commits intoHackYourFuture:masterfrom
alquinex:week1_correction
Closed
corrected version homework week1#266alquinex wants to merge 2 commits intoHackYourFuture:masterfrom alquinex:week1_correction
alquinex wants to merge 2 commits intoHackYourFuture:masterfrom
alquinex:week1_correction
Conversation
remarcmij
reviewed
Feb 10, 2019
Week1/homework/app.js
Outdated
| Macbeth: './images/Macbeth.jpeg', | ||
| Julius_Caesar: './images/Julius_Caesar.jpeg', | ||
| Silas_Marner: './images/Silas_Marner.jpeg', | ||
| The_Gods_Are_Not_To_Blame: './images/The_Gods_Are _Not _To _Blame.jpeg', |
Collaborator
There was a problem hiding this comment.
The HTML validator gives this error message:
Error: Bad value ./images/The_Gods_Are _Not _To _Blame.jpeg for attribute src on element img: Illegal character in path segment: space is not allowed.
From line 13, column 602; to line 13, column 655
Rotimi</p><img src="./images/The_Gods_Are _Not _To _Blame.jpeg"></li><
| const li = document.getElementById(key); | ||
| const img = document.createElement('img'); | ||
| li.appendChild(img); | ||
| img.setAttribute('src', `${bookCovers[key]}`); |
Collaborator
There was a problem hiding this comment.
HTML validation error (for all <img> tags):
Error: An img element must have an alt attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images.
From line 13, column 88; to line 13, column 129
ama Ba</p><img src="./images/So_Long_A_Letter.jpeg"></li><
Author
There was a problem hiding this comment.
Hi Jim,
All errors have been fixed and correction made. It should be fine now
remarcmij
previously approved these changes
Feb 10, 2019
Collaborator
remarcmij
left a comment
There was a problem hiding this comment.
Hi Alusine, there are some HTML validation errors, but the JS part is fine after our 1-on-1 session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.