This repository was archived by the owner on May 14, 2024. It is now read-only.
JavaScript2 Week1 HomeWork from Ann-Grabetski#463
Closed
Ann-Grabetski wants to merge 4 commits intoHackYourFuture:masterfrom
Closed
JavaScript2 Week1 HomeWork from Ann-Grabetski#463Ann-Grabetski wants to merge 4 commits intoHackYourFuture:masterfrom
Ann-Grabetski wants to merge 4 commits intoHackYourFuture:masterfrom
Conversation
wilgert
suggested changes
Sep 1, 2019
wilgert
suggested changes
Sep 4, 2019
| const booksList = document.createElement(`ul`); | ||
| document.body.insertBefore(booksList, document.body.childNodes[2]); | ||
|
|
||
| for (const book of booksArray) { |
Week1/homework/app.js
Outdated
| } | ||
| }; | ||
|
|
||
| for (const book of booksArray) { |
Contributor
There was a problem hiding this comment.
Don't forget to remove debugging code like this loop before submitting your homework.
| original_language.appendChild(original_languageContent); | ||
| }; | ||
|
|
||
| for (const book of booksArray) { |
Contributor
There was a problem hiding this comment.
Although this solution to add the images works it is not what was asked for in the instructions. Please read 1.7 and 1.8 again. And implement it like it is written there.
Author
|
Hi @wilgert , |
Author
|
Hi @wilgert , |
wilgert
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.