This repository was archived by the owner on May 14, 2024. It is now read-only.
Fixing style guide intro text#391
Merged
NoerGitKat merged 2 commits intoHackYourFuture:masterfrom Sep 9, 2020
Merged
Conversation
NoerGitKat
previously approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: I still need to improve this text a bit, but at least it's a start :)
I found it very confusing how the text made a sudden switch from visual style guide to coding style guide, as if the two are the same thing.
(In fact, I'm not sure how our students's workflow is with the repo etc. But I can imagine it might be way easier to just get them to install the Prettier extension in VS code and be done with it.)