Skip to content

ENH: Bump for ITK v5.3 release #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbirdso merged 3 commits into from
Nov 29, 2022
Merged

ENH: Bump for ITK v5.3 release #12

tbirdso merged 3 commits into from
Nov 29, 2022

Conversation

@tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Nov 28, 2022

Testing in ITKSplitComponents draft PR: InsightSoftwareConsortium/ITKSplitComponents#65

@tbirdso tbirdso requested review from dzenanz and thewtex November 28, 2022 16:07
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 28, 2022 •
edited
Loading

ITKSplitComponents is failing with an issue observed in ITKStrain prior to my opening this PR. As the error message originates from skbuild I have entered an issue there to track: scikit-build/scikit-build#805

Note that this issue blocks us from updating remote modules for v5.3.

@tbirdso tbirdso force-pushed the bump-itk branch 2 times, most recently from 5ab9492 to cfb9d2c Compare November 28, 2022 20:05
@tbirdso tbirdso linked an issue Nov 29, 2022 that may be closed by this pull request
Add ITKPythonPackage checkout step #13
Closed
@tbirdso tbirdso marked this pull request as ready for review November 29, 2022 00:05
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 29, 2022

Changes in this PR including ITKPythonPackage update step allow ITK modules to build against v5.3.0 successfully: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3569030832/jobs/5999692408

Also demonstrated that an older ITKPythonPackage tag can be used to revert to earlier build scripts, in this case recreating the now-fixed Windows failure: https://github.com/tbirdso/ITKSplitComponents/actions/runs/3569679773/jobs/5999869846

@dzenanz I have made several changes since your last review, I'll leave this up in case you'd like to re-review in the morning before merge.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 29, 2022

Thank you @dzenanz !

@tbirdso tbirdso merged commit 51ed0d9 into main Nov 29, 2022
@thewtex thewtex deleted the bump-itk branch November 29, 2022 14:50
SimonRit pushed a commit to SimonRit/RTK that referenced this pull request Nov 29, 2022
ENH: Bump for ITK v5.3 release
2f012b7 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
@SimonRit SimonRit mentioned this pull request Nov 29, 2022
Merged
SimonRit pushed a commit to SimonRit/ITKCudaCommon that referenced this pull request Nov 29, 2022
ENH: Bump for ITK v5.3 release
4e510aa 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
@SimonRit SimonRit mentioned this pull request Nov 29, 2022
Merged
SimonRit pushed a commit to SimonRit/RTK that referenced this pull request Nov 29, 2022
ENH: Bump for ITK v5.3 release
3641174 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
SimonRit pushed a commit to SimonRit/RTK that referenced this pull request Nov 29, 2022
ENH: Bump for ITK v5.3 release
c87911c 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
@tbirdso tbirdso mentioned this pull request Dec 1, 2022
Merged
SimonRit pushed a commit to SimonRit/RTK that referenced this pull request Dec 14, 2022
ENH: Bump for ITK v5.3 release
43c5c38 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
hjmjohnson pushed a commit to hjmjohnson/RTK that referenced this pull request Jan 26, 2025
@hjmjohnson
ENH: Bump for ITK v5.3 release
a4b9014 
Mirrors InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ITKPythonPackage checkout step

3 participants

@tbirdso @dzenanz