Fix: apply length check on type + scope + message (closes #35)#42
Merged
Fix: apply length check on type + scope + message (closes #35)#42
Conversation
JPeer264
approved these changes
Sep 8, 2017
Owner
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. The only thing what can happen is that the input is empty but everything else is long enough it would work.
Repository owner
deleted a comment from
coveralls
Sep 8, 2017
…-cli into fix/checkCompleteLength
…mantic-git-commit-cli into fix/checkCompleteLength
JPeer264
approved these changes
Oct 1, 2017
Repository owner
deleted a comment from
coveralls
Oct 1, 2017
Repository owner
deleted a comment from
coveralls
Oct 1, 2017
Repository owner
deleted a comment from
coveralls
Oct 1, 2017
|
Changes Unknown when pulling 45e6d63 on fix/checkCompleteLength into ** on master**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.