fix: updating the node-fetch target to handle form-urlencoded requests#187
Merged
develohpanda merged 3 commits intoKong:masterfrom Nov 28, 2020
Merged
Conversation
DMarby
suggested changes
Oct 21, 2020
DMarby
left a comment
There was a problem hiding this comment.
Thank you for this PR, looks great!
Just have one question regarding how the encodedParams are used.
Contributor
Author
|
@DMarby I've removed |
DMarby
approved these changes
Oct 22, 2020
develohpanda
approved these changes
Nov 27, 2020
Contributor
develohpanda
left a comment
There was a problem hiding this comment.
LGTM, thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node-fetchtarget was originally sendingx-www-form-urlencodedas a JSON object tobodywhen it should be encoded withURLSearchParamsas per the docs.I also added a line break in the
multipart/form-datahandling so theformData.append();calls have a little bit of room to breathe.