[Reducer] Look for already processed multidimentional value and push the data instead of assigning a new one in body params#93
Merged
darrenjennings merged 1 commit intoKong:nextfrom Mar 10, 2019
Conversation
…the data instead of assiging a new one
Author
|
Build is already failing in master, hence it is also in the PR |
|
thanks! i'll review the build and see why it's failing |
Author
|
Ping |
Contributor
|
Looks good to me, thanks @SamvelRaja! Will probably bundle a few small fixes like this into a next single release. |
darrenjennings
added a commit
that referenced
this pull request
Apr 25, 2019
* feat(powershell) add powershell files - add test fixtures - add to available targets * fix(reducer): reduce multidimensional query strings correctly (#93) * fix(headers) reduce normal using Object.assign * fix(node) remove extra whitespace in node fixtures * fix(node) switch from util.inspect to stringify-object module - Consistent formatting across Node versions - Fixes cross-node-version tests * chore(lint) fixes - Deprecate utils functions (util._extend -> Object.assign). - Invoke assertion `should` methods. - Remove unnecessary escape chars. * chore(travis) use later versions of node * chore(test) disable posttest run for now * style(spelling) fix misspelled attachment - when we switched from util._extend to Object.assign, the ordering of the headers seemed to be affected, which means we can switch back to a normal `reduce` instead of `reduceRight` * test(requests) disable deep equal for https - Mockbin returns http url even when request is for https url * test(targets) build in skip mechanism for failures * test(headers) fix headers consistencies w/fixtures * test(go) fix header order, human readable Fixes #125, #124 From #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
If the body param has the values
[ {"name": "key", "value": "value"}, {"name": "foo", "value": "bar1"}, {"name": "foo", "value": "bar2"}, {"name": "foo", "value": "bar3"} ]The reducer function were generating it as,
{ "key": "value", "foo": [["bar1", "bar2"], "bar3"] }On passing the above value to
qsmodule results inkey=value&foo=&foo=bar3This fix ensure we are not blindly adding the query params into the array (results in nested array)
hence, the out put of reducer function would be
{ "key" : "value", "foo": ["bar1", "bar2", "bar3"] }on passing to
qsreturnskey=value&foo=bar1&foo=bar2&foo=bar3which was the desired value.P.S: Feel free to comment or reject the PR.