add types to console and remove consoleBG#2916
Open
PatrickMatthiesen wants to merge 2 commits intoMALSync:masterfrom
Open
add types to console and remove consoleBG#2916PatrickMatthiesen wants to merge 2 commits intoMALSync:masterfrom
PatrickMatthiesen wants to merge 2 commits intoMALSync:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
@lolamtisch Anything that I need to do to get this approved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we had an entire extra console log file just to distinguish the service worker from the rest of the logs.
I have made it a variable in webpack so we can resolve it at build time and change the text that way.
I also added typescript types to the file and fixed some names to remove linter errors.