Conversation
Conflicts: index.html
Conflicts: index.html
Conflicts: index.html
7 tasks
current problem is that this._layerControlHTML is not connected when disconnecting the map-extent from the DOM (manually), so unable to hide/unhide the extents' root fieldset line 620 map-extent.js
…ange TemplatedLayer and related child layer types.
Prevent excessive disconnection / reconnection of layers and map-extents when clicking on layer control entries, by upping the 'moving' px threshold and calculating if the entry has changed position through the dragging event (do disconnect/reconnect) or not (do not do dis/re). In map-feature, look for data-moving on layer or map-extent element, regardless of whether it's a local or remote layer (light dom vs shadow dom).
Synchronize opacity attribute, property and slider in layer control (note: works slightly differently than layer.opacity, which doesn't "sprout" the opacity attribute when set via layer control) Fix bug when setting map-extent.hidden in shadow dom of layer element
/layer-._calculateExtent(). To Do: make it efficient / memoize extent value until extent actually changes.
Member
|
Tests Needed -
extension -
docs -
if (
this._layerEl.checked &&
!this._layerEl.hidden &&
this._mapmlLayerItem
) {
To Do when developing map-link
_getMinMaxZoom() {
let input = this.querySelector('map-input[name=zoom]') || this.querySelector("map-meta[name=zoom]") || this.parentLayer.shadowRoot? this.parentLayer.shadowRoot.querySelector("map-meta[name=zoom]") : this.parentLayer.querySelector("map-meta[name=zoom]");
if (input) {
//
} else {
// use projection fallback
}
}
Bugs that still exists Bugs discovered on main
To Do Before closing PR
|
Get rid of (some) use of live map tiles from NRCan. Add temporary todo list of still-failing tests
the documented behaviour too. domApi changes due to prettier...
usage. Lack of catch processing led to slow processing when pasting an invalid / unavailable link onto the map.
…ing to Number, update tests accordingly; some prettier formatting for tms and clientTemplatedTileLayer tests
…ead of String, update tests
9 tasks
mapml-viewer.width, .height, .lat, .lon. Amend tests to enforce this.
…code which was meant to be removed + remove page.pause + remove extra files
…value (if exists) or 1.0 as default; add waitfortimeout and slowmo to fix flaky tests
Member
Author
|
Small issue discovered: when you change a remote, hidden, checked map-extent from checked to not checked in the SD (remove the attribute), then remove the hidden attribute to unhide the extent in the layer control, the extent appears checked in the layer control, and changing the checkbox to unchecked now displays the extent. (discovered in geoserver testing). |
9 tasks
38de907 to
fd68b1a
Compare
This was referenced Nov 8, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tests Needed -
layer-hidden attribute test.extension - Maps4HTML/mapml-extension#66
docs - Maps4HTML/web-map-doc#135
To Do when developing map-link
Bugs that still exists
- Debug Mode - When you check and uncheck a layer in debug mode, the layer bounds don't show up when the layer is checked, but do when layer is unchecked. Behaves oppositely.Bugs discovered on main
To Do Before closing PR
Closes #886