Closed
Conversation
Allow the MessageInputBar to be used as a subview rather than an inputAccessoryView
Member
|
@nathantannar4 Is this the full PR? 🤔 |
SD10
reviewed
Jun 27, 2018
| import Foundation | ||
|
|
||
| public struct KeyboardNotification { | ||
|
|
Member
There was a problem hiding this comment.
I think this type is not MessageInputBar specific enough to be in this project. Ideally, the MessageInputBar should have no idea that it is the inputAccessoryView. A user can use it as such or as any other view. But I want to ignore the notion of a keyboard
SD10
reviewed
Jun 27, 2018
Member
SD10
left a comment
There was a problem hiding this comment.
I actually have another project in progress, solely related to keyboard handling. Let's re-evaluate after I get the current features like autocomplete manager in MessageKit
Member
Author
|
@SD10 file system only had the reference to the file, KeyboardManager there now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the MessageInputBar to be used as a subview rather than an inputAccessoryView