Added new methods in MessagesLayoutDelegate for adjusting alignment of message top and bottom labels #1671
Merged
martinpucik merged 6 commits intomasterfrom Feb 8, 2022
Merged
Added new methods in MessagesLayoutDelegate for adjusting alignment of message top and bottom labels #1671martinpucik merged 6 commits intomasterfrom
MessagesLayoutDelegate for adjusting alignment of message top and bottom labels #1671martinpucik merged 6 commits intomasterfrom
Conversation
…gnments CHangelog
…gnments Fix example MessageKit local package import
Kaspik
requested changes
Feb 3, 2022
Member
Kaspik
left a comment
There was a problem hiding this comment.
I know it will be small but could you please create super small V4 Migration info section into Readme file for people that upgrade from V3?
Contributor
Author
|
There are no breaking changes yet in 4.0. I'd add the migration doc when there is something to migrate 😁 |
Member
|
Well you have to add new functions when upgrading to it, they are not optional, right? 😅 |
Contributor
Author
|
There are default implementations in |
Kaspik
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
MessagesLayoutDelegatemethods for adjusting message top/bottom label alignments without the need to subclass MessageSizeCalculatorsDoes this close any currently open issues?
N/A