Fix for SwiftUI example IBAV position issues (example app)#1807
Merged
Kaspik merged 2 commits intoMessageKit:mainfrom Aug 31, 2023
Merged
Fix for SwiftUI example IBAV position issues (example app)#1807Kaspik merged 2 commits intoMessageKit:mainfrom
Kaspik merged 2 commits intoMessageKit:mainfrom
Conversation
added 2 commits
August 23, 2023 20:16
…eArea modifier to the body (iOS 14+)
Author
|
Script says it can't find my commit, did I do something wrong?
|
Kaspik
approved these changes
Aug 23, 2023
|
not works from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes IBAV position issues in the SwiftUI example of the example app by adding
ignorersSafeAreamodifier to the body.I also fixed a small warning in the example app while I was at it.
Does this close any currently open issues?
#1734 and a couple of others probably
Any other comments?
The fix also needs IBAV 6.3.0 to work properly, which was added to MessageKit today. Hence I send this PR today.
Also iOS 13 users are out of luck..., but it forced me to do a iOS version check which made things a bit ugly.
Where has this been tested?
iPhone and iPad simulator and iPhone Xs with iOS 16
MessageKit 4.2.0