Fix scroll to last item to take section inset into account#1832
Fix scroll to last item to take section inset into account#1832hidoon wants to merge 10 commits intoMessageKit:mainfrom
Conversation
Kaspik
left a comment
There was a problem hiding this comment.
Do you have a video with the fix implemented?
|
Hi @hidoon ! It looks like this issue did not fully still not solved. For example, in the Example code's Advanced VC, after entering the advanced vc, it is also not scrolling correctly to the bottom. Would you mind helping take a look what is wrong? Thank you so much! (I was using a similar approach in the example code for my own project, and have spent 10+ hrs already but still couldn't solve the issue myself 😢 ) Update - It seems like the issue happens when the custom input bar's height is larger than the default input bar's
|
|
Another issue I found is: if I created a custom footer view for the messages collection view, scroll to bottom has a large and very noticeable padding at the bottom, and seems to be the exactly one footer cell's height. |
|
hi @luoshuaiqing, as far as I know, the |
Oh I am not talking about scrolling down. I am talking about
I am referring to |
|
@luoshuaiqing Oh, I see. I think the problem you face is the height of your custom view is not taken into account and |
|
Thanks for the advice, but it looks like it didn't work after I do something like |
|
hey luoshuaiqing and other who needs help, there is a function in |
|
Is this ready to be merged given the conversation here? |
There was a problem hiding this comment.
I dont think 3 times called scroll function is better

What does this implement/fix? Explain your changes.
This correction addresses the bug (issue #1830) where
scrollToLastItem(at:animated:)didn't perform as expected. Previously, it would scroll to the last item without considering thesectionInset, eliminating the gap between the last cell andinputBarAccessoryView.Does this close any currently open issues?
Yes it does, (issue #1830 )
Where has this been tested?
Devices/Simulators:
iOS Version:
Swift Version:
MessageKit Version: