Enhancement/transit info detection#520
Conversation
Sources/Views/MessageLabel.swift
Outdated
There was a problem hiding this comment.
Why did we change .addressComponents here?
There was a problem hiding this comment.
It has been marked as "// Deprecated in favor of components" so I updated it
There was a problem hiding this comment.
Looks good to me. I don't see this as deprecated in the Foundation docs. Just need to test that it works before merging 👍
There was a problem hiding this comment.
The comments not documented in Apple API Reference, so please make sure this is available in iOS9 - iOS11.(IMO, maybe we can do this change after documented in API Reference 😄 )
There was a problem hiding this comment.
happy to take it out if you prefer, but prob a good one to remember for when it does go
Sources/Views/MessageLabel.swift
Outdated
There was a problem hiding this comment.
Maybe change the parameter name transitInformationComponents -> components
Sources/Views/MessageLabel.swift
Outdated
There was a problem hiding this comment.
We could just use transitInfoComponents, shorter 😅
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
What does this implement/fix? Explain your changes.
This PR adds transit information detection option to message labels
Does this close any currently open issues?
Contributes but does not complete Data detectors for MessageLabel #71
Where has this been tested?
Devices/Simulators: iphone 8
iOS Version: … 11.2
Swift Version: …4
MessageKit Version: 0.13.1