Added convenience method to set properties for all MessageSizeCalcula…#697
Merged
SD10 merged 3 commits intoMessageKit:developmentfrom May 23, 2018
Merged
Added convenience method to set properties for all MessageSizeCalcula…#697SD10 merged 3 commits intoMessageKit:developmentfrom
SD10 merged 3 commits intoMessageKit:developmentfrom
Conversation
Member
Author
|
@SD10 Let's provide one shot method. |
BasThomas
reviewed
May 22, 2018
| return calculator.sizeForItem(at: indexPath) | ||
| } | ||
|
|
||
| /** Set `incomingAvatarSize` of all `MessageSizeCalculator`s */ |
Contributor
There was a problem hiding this comment.
Nit, but what about a triple / (///) instead of these multiline comments?
|
Looks good to me! Thanks for doing this. |
SD10
reviewed
May 22, 2018
| } | ||
|
|
||
| /// Set `incomingAvatarSize` of all `MessageSizeCalculator`s | ||
| open func setMessageIncomingAvatarSize(_ newSize: CGSize) { |
Member
There was a problem hiding this comment.
Think these should be public and not open? They're helper methods. I don't know if we should allow people to override? I don't see any major harm in leaving it but what do you think?
Member
Author
There was a problem hiding this comment.
No big differences I think, I'll change this to public.
Member
|
🙏 I'm so lucky to have other contributors 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for #694 .