Skip to content

Integrate MessageInputBar as a dependency#732

Merged
SD10 merged 11 commits intodevelopmentfrom
split-messageinputbar
Sep 17, 2018
Merged

Integrate MessageInputBar as a dependency#732
SD10 merged 11 commits intodevelopmentfrom
split-messageinputbar

Conversation

@nathantannar4
Copy link
Member

This PR removes all source code / test related to MessageInputBar and replaces by setting MessageInputBar/Core as a new dependency. This will also for separate development of each library without bloating MessageKit through the additions such as autocomplete (available in MessageInputBar/AutocompleteManager

If there are any Cartfile users here please let me know if the changes I made to the Cartfiles are correct.

@nathantannar4
Copy link
Member Author

For #730

Cartfile.private Outdated
@@ -1,2 +1,3 @@
github "Quick/Quick" ~> 1.2.0
github "Quick/Nimble" ~> 7.0.3
github "MessageKit/MessageInputBar" ~> 0.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be declared in a Cartfile, not Cartfile.private

@SD10
Copy link
Member

SD10 commented Jun 17, 2018

@nathantannar4 We'll also need to update the Circle CI configuration to build the dependencies. You can see how we do it at Moya

@SD10
Copy link
Member

SD10 commented Jun 27, 2018

@nathantannar4 Want me to take over this one?

@nathantannar4
Copy link
Member Author

@SD10 Ya I don't know why the build is failing, something to do with the Carthage things I think

@nathantannar4 nathantannar4 added this to the 2.0 milestone Jul 26, 2018
@SD10
Copy link
Member

SD10 commented Aug 7, 2018

If any @MessageKit/contributors want to pick this one up that would be 🔥 😊 Need to link this in a way that supports both CocoaPods and Carthage

@zhongwuzw
Copy link
Member

Emm, what about make MessageInputBar as a git submodule?

@SD10
Copy link
Member

SD10 commented Aug 22, 2018

@zhongwuzw I'm not familiar with git submodules. I'd like to set up this project the same way as something like Moya

@ndonald2
Copy link

Carthage should allow specifying other dependencies without using a submodule. My guess is that this is why it's failing (input bar dependency in the private, not public, cartfile)

#732 (comment)

@nathantannar4 nathantannar4 force-pushed the split-messageinputbar branch from 0eb322a to dfe727c Compare August 26, 2018 17:05
@SD10
Copy link
Member

SD10 commented Aug 26, 2018

@nathantannar4 We need to create a new file Cartfile and list the dependency there. The Cartfile.private is used for dev and Cartfile for release

Check out the Cartfile at Moya

@nathantannar4
Copy link
Member Author

@SD10 we do have a Cartfile

Sent with GitHawk

@nathantannar4
Copy link
Member Author

It seems to build it correctly now, some random test error occurred though

Sent with GitHawk

@SD10
Copy link
Member

SD10 commented Aug 26, 2018

@nathantannar4
Copy link
Member Author

Works now

Sent with GitHawk

Copy link
Member

@zhongwuzw zhongwuzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍 ,waiting for 2.0

@SD10
Copy link
Member

SD10 commented Aug 28, 2018

Will review this weekend. I’d like to see this make it in 2.0. We’ll have to do a beta for a change this big

Sent with GitHawk

Copy link
Member

@SD10 SD10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks like we won't be able to do a 1.1 release but this is good to go and I need it 😓

@SD10 SD10 merged commit 230e067 into development Sep 17, 2018
@SD10 SD10 removed the under review label Sep 17, 2018
@nathantannar4 nathantannar4 deleted the split-messageinputbar branch September 29, 2018 18:46
@SD10 SD10 modified the milestones: 2.1, 2.0 Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants