Integrate MessageInputBar as a dependency#732
Conversation
|
For #730 |
Cartfile.private
Outdated
| @@ -1,2 +1,3 @@ | |||
| github "Quick/Quick" ~> 1.2.0 | |||
| github "Quick/Nimble" ~> 7.0.3 | |||
| github "MessageKit/MessageInputBar" ~> 0.2.0 | |||
There was a problem hiding this comment.
This would need to be declared in a Cartfile, not Cartfile.private
|
@nathantannar4 We'll also need to update the Circle CI configuration to build the dependencies. You can see how we do it at Moya |
|
@nathantannar4 Want me to take over this one? |
|
@SD10 Ya I don't know why the build is failing, something to do with the Carthage things I think |
|
If any @MessageKit/contributors want to pick this one up that would be 🔥 😊 Need to link this in a way that supports both CocoaPods and Carthage |
|
Emm, what about make |
|
@zhongwuzw I'm not familiar with git submodules. I'd like to set up this project the same way as something like Moya |
|
Carthage should allow specifying other dependencies without using a submodule. My guess is that this is why it's failing (input bar dependency in the private, not public, cartfile) |
0eb322a to
dfe727c
Compare
|
@nathantannar4 We need to create a new file Check out the Cartfile at Moya |
|
It seems to build it correctly now, some random test error occurred though Sent with GitHawk |
|
Works now Sent with GitHawk |
|
Will review this weekend. I’d like to see this make it in 2.0. We’ll have to do a beta for a change this big Sent with GitHawk |
SD10
left a comment
There was a problem hiding this comment.
Ok looks like we won't be able to do a 1.1 release but this is good to go and I need it 😓
This PR removes all source code / test related to MessageInputBar and replaces by setting
MessageInputBar/Coreas a new dependency. This will also for separate development of each library without bloating MessageKit through the additions such as autocomplete (available inMessageInputBar/AutocompleteManagerIf there are any Cartfile users here please let me know if the changes I made to the Cartfiles are correct.