Updated way to calculate the bottom content inset#762
Updated way to calculate the bottom content inset#762davidvpe wants to merge 3 commits intoMessageKit:masterfrom
Conversation
|
Thanks for submitting this! We will try to get it in the next release Sent with GitHawk |
|
@davidvpe Thanks for your fix, can you add a |
|
@zhongwuzw Changelog added! |
| ### Fixed | ||
|
|
||
| - Fixed the way `MessagesViewController` calculates the bottom content inset when the keyboard is shown. | ||
| [#761](https://github.com/MessageKit/MessageKit/issues/761) by [@davidvpe](https://github.com/davidvpe). |
There was a problem hiding this comment.
How about: Fixed the calculation the bottom content inset for `MessagesCollectionView"?
There was a problem hiding this comment.
This is also in the wrong section, it should be under Upcoming Release
|
I need to test this before merging to make sure it doesn't mess up my company's app |
|
@davidvpe I took a moment to test this out with the new example app I'm making an it looks like its still not sizing the bottom correctly Its added more spacing than needed, see below |
|
It works on iPhone/iPhone+ models so I believe the issue is that you are not deducting the iPhoneXBottomInset |
|
I think it's the iPhoneX. |
|
@davidvpe How are you setting up the container controller? |
|
@nathantannar4 maybe we should add |
|
@nathantannar4 I am a bit caught up at work but as soon as I get some free time I'll add it. |
|
@nathantannar4 I see there is a messageCollectionViewBottomInset in MessagesViewController maybe I should just add it to the equation and that's it. Edit: Turns out it is being subtracted already from the equation. Huh |
|
Yeah we really need to do a thorough analysis of what's going on here. It's such a struggle to get the inset working for everyone. We make changes for one app / device and break things in another We should definitely expose some |
|
@davidvpe @SD10 I think this is better than what we currently have. I can do a separate PR for adding additional top/bottom inset so devs can adjust those as needed and we shouldn't have to handle more of these issues. Sent with GitHawk |
|
Yeah @nathantannar4 it's just pending me testing this change in our application. I have a tight deadline at work right now so I won't get to it till this weekend. We use Carthage as a dependency manager -- so testing MessageKit changes is a little inconvenient for me with this setup |


What does this implement/fix? Explain your changes.
Modified the way MessagesViewController calculate the Collection View bottom content inset when showing the keyboard
Does this close any currently open issues?
#761
Any relevant logs, error output, etc?
No
Any other comments?
No
Where has this been tested?
Devices/Simulators: All simulators + Real iPhone 7
iOS Version: 11.3
Swift Version: 4.0
MessageKit Version: 1.0.0