update to swift 4.2#880
update to swift 4.2#880moldovaniosif wants to merge 2 commits intoMessageKit:masterfrom TAGonSoft:master
Conversation
| // MARK: - Properties | ||
|
|
||
| open let triangleView = UIView() | ||
| public let triangleView = UIView() |
There was a problem hiding this comment.
“open” is now simply “more public than public”, providing a very simple and clean model.
|
Definitely could used this merged. Unable to compile in Xcode 10 without the update to Swift 4.2. |
|
Tests failing Sent with GitHawk |
|
@nathantannar4, it looks like this is only failing because it’s using Xcode 9 (which does not support Swift 4.2) instead of using Xcode 10 during CircleCI builds. |
|
Correct, the CircleCi file needs to be updated along with this PR. Also, target branch should be development not master @moldovaniosif. Please make sure your changes are rebased onto development as we already have pending changes Sent with GitHawk |
|
@nathantannar4 thank you! I wasn’t sure what need to be done to update Circle CI to use the updated version of Xcode. I meant to add that in my first comment since others might not be familiar with Circle CI either. Sent with GitHawk |
|
Closing in favor of #883. @moldovaniosif appreciate you taking the time to do this 💪 Sent you an invite to the MessageKit org |
What does this implement/fix? Explain your changes.
Update project to support swift 4.2.
Does this close any currently open issues?
No.
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators: iPhone 7, Simulator 7, X;
iOS Version: 12.0
Swift Version: 4.2
MessageKit Version: 1.0.0