fix intrinsic content size for MessageLabel#889
fix intrinsic content size for MessageLabel#889nathantannar4 merged 2 commits intoMessageKit:developmentfrom
Conversation
SD10
left a comment
There was a problem hiding this comment.
This is good for me 👍 @nathantannar4 did you ever look into CI failing? I noticed you were playing with it in your Swift 4.2 PR. Think this is fine to merge without it passing though.
|
@SD10 ya this should build fine on Swift 4.2. @marius-serban please change the destination branch and add a CHANGELOG entry for upcoming release then it LGTM 👍 |
|
I changed this to point at |
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
|
@nathantannar4 You didn't check the CHANGELOG format before merging this 😓 |
|
I did, what wasn't right about the format? Sent with GitHawk |
|
It's not in the CHANGELOG.md file. It's a new file 😂 |
|
Oh 😂 I thought it was the git diff just showing the difference. I'll fix it when I merge dev into master Sent with GitHawk |
What does this implement/fix? Explain your changes.
The
intrinsicContentSizeofMessageLabelisn't correct because it doesn't take thetextInsetsproperty into account; it just relies on theUILabelimplementation. This is a problem when usingMessageLabels in custom cells that use autolayout.Does this close any currently open issues?
nope
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators: …
iOS Version: …
Swift Version: …
MessageKit Version: …