Example chat screens do not scroll to the bottom on new message insertion.#899
Merged
nathantannar4 merged 1 commit intoMessageKit:developmentfrom Oct 10, 2018
hamzaozturk:development
Merged
Example chat screens do not scroll to the bottom on new message insertion.#899nathantannar4 merged 1 commit intoMessageKit:developmentfrom hamzaozturk:development
nathantannar4 merged 1 commit intoMessageKit:developmentfrom
hamzaozturk:development
Conversation
…eViewController. Moreover, there is an easier method to find the visible section. It is unnecessary to scroll to the bottom when title view updated.
Member
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isLastSectionVisible method returns wrong results for the BasicExampleViewController. Moreover, there is an easier method to find the visible section.
It is unnecessary to scroll to the bottom when title view updated.
What does this implement/fix? Explain your changes.
If you check Example Chat app, it does not scroll to the bottom on BasicExampleViewController. Actually, it does not scroll to the bottom on the other sections, too. Therefore, i changed the method to find the last section is visible.
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators: …
iOS Version: …
Swift Version: …
MessageKit Version: …