-
Notifications
You must be signed in to change notification settings - Fork 1
Addition of Message Definitions and associated artifacts #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test orders and responses Commit also includes additional CodeSystems required for event coding and a CapabilityStatement for validation
And changes to examples for validation against genomic StructureDefinitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the MessageHeader from MessageDefinitions.focus.
This is unnecessary as this is already a rule for FHIR Messages. Understand it is useful for a human reading the definition but technically it could lead to issues.
To allow additional Message Event codes
|
@KevinMayfield, this has now been fixed. FYI, we will be looking to migrate some profiles into NHSD depending on guidance from the profiling workshop and KevS, so you can consider these placeholders to allow us to build up the Genomics IG for the time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary as NHSDigital-MessageHeader is probably sufficient and I feel MessageHeader should be generic to allow middleware to handle messages independent of message content.
This is referring to CapabilityStatement
KevinMayfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrt to MedicationDefinitions
I think the optional focused items aren't necessary and may lead to conflicts with ServiceRequest profiles.
For example to make a Patient mandatory in this message. I think the ServiceRequest-Genomics should have patient mandatory (aggregation = bundled).
Patient does not need to be in the MessageDefinition.
The same would apply to all other resources (except for ServiceRequest)
|
Hi @KevinMayfield, Regarding the Capability statement comment. I only have the MessageHeader profile to trial a different ValueSet for message event codes related to genomics. I'm intending to merge the ValueSet with the NHSD message-events ValueSet once the final list has been agreed by the Genomics Programme (so I've got it here for demo purposes). Regarding the rest of the CapabilityStatement, this was added to ensure the correct profiles are targeted during validation (and I am also planning some restful interactions which will not be using messages). |
KevinMayfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have Message Event codesystem for genomics (well, in a genomics repo).
The handling of messages should be generic to enable middleware to handle them. So I would recommend either adding these codes to the NHS Digital Message Events Codesystem or moving this CodeSystem to NHS Digital IG.
Agreed, as mentioned in my other comment, I am just waiting on a finalised list of message types from Genomics before making the change in the NHSD repo (as I want to avoid multiple changes as codes change). The current system is for demo purposes until agreed by NHSE |
|
Approved. Recommend the MessageDefinition and profiling discussion is added to Design Authority agenda. |
|
@KevinMayfield, I'll have a look at the MessageDefinitions and add in the aggregation (I'll need to have a think about the types of aggregation allowed as I want to allow some resources, such as ServiceRequest, used in multiple contexts (e.g. on initial request, the patient resource should be bundled but on status updates, I would like this referenced instead so a single resource can be sent instead of the full bundle) |
No description provided.