Skip to content

add read/write permissions to allow issue creation #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
egpbos merged 2 commits into from
Jul 11, 2023
Merged

add read/write permissions to allow issue creation #340

egpbos merged 2 commits into from
Jul 11, 2023

Conversation

@bvreede
Copy link
Contributor

@bvreede bvreede commented Apr 7, 2023 •
edited
Loading

Adding permissions to the workflow allows issues to be created.

See the first few lines of the action usage at https://github.com/JasonEtco/create-an-issue

I made this change in my own project, which fixed permissions to create issues, but still failed when deleting them.

This is fixed when also giving write permissions for content; see this action run.

Closes #332

@bvreede bvreede requested a review from lyashevska April 7, 2023 09:11
@bvreede
Copy link
Contributor Author

bvreede commented Apr 7, 2023

Failing windows tests still failing (see #326) >.<

@egpbos
Copy link
Collaborator

egpbos commented Jun 8, 2023

Why is it write + write here? In the example you linked to, you only used read + write.

@lyashevska does this fix your issue?

@bvreede
Copy link
Contributor Author

bvreede commented Jul 7, 2023

@egpbos apologies for the late reply. No, I needed to set

permissions:
  contents: write
  issues: write

for the workflow to be able to run successfully, and be able to both create the issues, and subsequently delete the template files.

See this file in the commit where the workflow ran completely.

@egpbos
Copy link
Collaborator

egpbos commented Jul 11, 2023

Clear, LGTM!

@egpbos egpbos merged commit b261530 into main Jul 11, 2023
@sjvrijn sjvrijn deleted the action-permissions-332 branch May 3, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyashevska lyashevska Awaiting requested review from lyashevska

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Read and write permissions to GITHUB_TOKEN in a new organisation are required for next_steps workflow

3 participants

@bvreede @egpbos