Skip to content

Conversation

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Mar 12, 2023

PR Checklist

What is the current behavior?

All Android Label's defaulted to vertical-align top which never matched iOS. This has been broadly complained about and a PR was even submitted by an excellent contributor @Logikgate #8216 which properly addressed the issue but was closed years ago citing breaking changes.

What is the new behavior?

All Android Label's will default to vertical-align middle now to match iOS default. This is a long desired breaking change.

closes #3829
References:
#5977
#8216
https://github.com/orgs/NativeScript/discussions/10058

BREAKING CHANGES:

All Android Label's will default to vertical-align middle now to match iOS default. If you preferred the previous default top, you can just explicitly set it.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 24d3903. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Mar 12, 2023
@NathanWalker NathanWalker added this to the 8.5 milestone Mar 12, 2023
@NathanWalker NathanWalker merged commit a23c8bd into main Mar 13, 2023
@NathanWalker NathanWalker deleted the fix/android-label-default-vert-middle branch March 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertically center label on android by default

3 participants