fix(android): default Label to vertical-align middle #10233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
All Android
Label's defaulted to vertical-aligntopwhich never matched iOS. This has been broadly complained about and a PR was even submitted by an excellent contributor @Logikgate #8216 which properly addressed the issue but was closed years ago citing breaking changes.What is the new behavior?
All Android
Label's will default to vertical-alignmiddlenow to match iOS default. This is a long desired breaking change.closes #3829
References:
#5977
#8216
https://github.com/orgs/NativeScript/discussions/10058
BREAKING CHANGES:
All Android
Label's will default to vertical-alignmiddlenow to match iOS default. If you preferred the previous defaulttop, you can just explicitly set it.