Skip to content

fix: ts-patch transform #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Jan 5, 2026
Merged

fix: ts-patch transform #11041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 7 additions & 21 deletions packages/webpack5/src/transformers/NativeClass/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default function (context: ts.TransformationContext, ...args) {
return (sourceFile: ts.SourceFile) => {
if (sourceFile.isDeclarationFile) return sourceFile;
let mutated = false;

// Minimal mutable shape
type MutableNode = ts.Node & {
flags?: ts.NodeFlags;
Expand Down Expand Up @@ -182,8 +182,8 @@ export default function (context: ts.TransformationContext, ...args) {
}

function visitNode(node: ts.Node): ts.Node {
// Do not traverse synthesized helper trees; leave them intact
if (((node as MutableNode).flags ?? 0) & ts.NodeFlags.Synthesized ) {
// Do not traverse synthesized helper trees; leave them intact
if (((node as MutableNode).flags ?? 0) & ts.NodeFlags.Synthesized) {
return node;
}
if (ts.isSourceFile(node)) {
Expand Down Expand Up @@ -223,7 +223,9 @@ export default function (context: ts.TransformationContext, ...args) {
}
const result: ts.Statement[] = [];
for (const statement of statements) {
if (((statement as MutableNode).flags ?? 0) & ts.NodeFlags.Synthesized) {
if (
((statement as MutableNode).flags ?? 0) & ts.NodeFlags.Synthesized
) {
result.push(statement);
continue;
}
Expand Down Expand Up @@ -282,22 +284,6 @@ export default function (context: ts.TransformationContext, ...args) {
}
return [changed ? factory.createNodeArray(result) : statements, changed];
}


// we detect ts-patch
if (args.length) {
const statements= ts.visitNodes(sourceFile.statements, visitNode) as unknown as ts.Statement[];
if (!mutated) {
return sourceFile;
}
const updatedSource = factory.updateSourceFile(sourceFile, statements as unknown as ts.Statement[]);
// Do NOT clear or rebind the entire SourceFile here. Doing so can break TS's
// import usage analysis and lead to import elision. The factory/update API
// preserves parents/bindings for original nodes (like imports). We only
// synthesize/bind the newly inserted class replacement statements.
return updatedSource;
}

const updated = ts.visitNode(sourceFile, visitNode) as ts.SourceFile;
if (!mutated) return sourceFile;
return updated;
Expand Down Expand Up @@ -339,4 +325,4 @@ function setSynthesizedRangeRecursive(node: ts.Node): void {
function setOriginalRecursive(node: ts.Node, original: ts.Node): void {
ts.setOriginalNode(node, original);
ts.forEachChild(node, (child) => setOriginalRecursive(child, original));
}
}