feat: Scoped Packages #7911

vakrilov · 2019-10-07T14:21:46Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

Introduce @nativescript/core package.

Related to #4041 #7895

SvetoslavTsenov · 2019-10-07T15:56:13Z

test

SvetoslavTsenov · 2019-10-14T08:44:10Z

test --ignore ngapps api24 ios12

DevelopmentWorkflow.md

nativescript-core/http/http-request/http-request.android.ts

nativescript-core/index.d.ts

nativescript-core/index.ts

nativescript-core/index.d.ts

SvetoslavTsenov · 2019-10-15T10:06:33Z

test --ignore ngapps branch_nativescript_dev_webpack#ns-scope-in-host-resolver ios12 api24

nativescript-core/ui/core/control-state-change/control-state-change.android.ts

nativescript-core/ui/dialogs/dialogs-common.ts

nativescript-core/ui/index.d.ts

nativescript-core/ui/index.ts

DevelopmentWorkflow.md

SvetoslavTsenov · 2019-10-15T11:53:55Z

test --ignore ngapps branch_nativescript_dev_webpack#ns-scope-in-host-resolver ios12 api24

SvetoslavTsenov · 2019-10-15T11:54:32Z

test --ignore ngapps ios12 api24

vakrilov · 2019-10-15T13:37:47Z

test --ignore ngapps ios12 api24

vakrilov · 2019-10-16T10:40:06Z

test --ignore

Co-Authored-By: Martin Yankov <m.i.yankov@gmail.com>

SvetoslavTsenov · 2019-10-16T16:10:47Z

test --ignore ngapps api24 ios12

vakrilov · 2019-10-16T18:38:10Z

test --ignore ngapps api24 ios12

cla-bot bot added the cla: yes label Oct 7, 2019

vakrilov force-pushed the scoped-packages-generate-master branch 3 times, most recently from 42160e5 to f0c50e0 Compare October 10, 2019 20:02

vakrilov marked this pull request as ready for review October 11, 2019 20:42

vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from 3f584b3 to 864b444 Compare October 11, 2019 21:13

MartoYankov reviewed Oct 14, 2019

View reviewed changes

vakrilov force-pushed the scoped-packages-generate-master branch from 49bea9c to d44d249 Compare October 15, 2019 06:29

MartoYankov reviewed Oct 15, 2019

View reviewed changes

vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from 1c15ae9 to c58ec1f Compare October 15, 2019 13:37

MartoYankov approved these changes Oct 16, 2019

View reviewed changes

vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from e5abd0c to 4345d3c Compare October 16, 2019 12:55

vakrilov added 8 commits October 16, 2019 16:43

chore: move tns-core-modules to nativescript-core

67bf6b4

chore: preparing compat generate script

faa240f

chore: add missing definitions

8b6e8e5

chore: no need for http-request to be private

73887ba

chore: packages chore

73b3bc8

test: generate tests for tns-core-modules

011cefd

chore: add anroid module for consistency

4437b08

chore: add .npmignore

22caa10

SvetoslavTsenov and others added 22 commits October 16, 2019 16:47

chore: update NATIVESCRIPT_CORE_ARGS

80d23af

chore: fix compat pack

7b7434b

chore: fix tslint errors

67b73f1

chore: fix ui-test-app build with linked modules

b632585

chore: Application, ApplicationSettings, Connectivity and Http

e32c2c3

chore: export Trace, Profiling and Utils

5b69c4c

refactor: Static create methods for ImageSource

06235a1

chore: fix deprecated usages of ImageSource

83a15a0

chore: move Span and FormattedString to ui

ff0a003

chore: add events-args and ImageSource to index files

7a85180

chore: check for CLI >= 6.2 when building for IOS

d4059aa

chore: update travis build

cf501d8

chore: copy Pod file to compat package

0d561f5

chore: update error msg ui-tests-app

16f05b5

refactor: Apply suggestions from code review

3e3314e

Co-Authored-By: Martin Yankov <m.i.yankov@gmail.com>

chore: typings and refs

1d413f8

chore: add missing d.ts files for public API

657aec4

chore: adress code review FB

24fb668

chore: update api-report

1488137

chore: dev-workflow for other apps

bc4e293

chore: api update

bdb1336

chore: update api-report

babb3a7

vakrilov force-pushed the scoped-packages-generate-master branch from 4345d3c to babb3a7 Compare October 16, 2019 13:53

vakrilov merged commit cc97a16 into master Oct 16, 2019

vakrilov deleted the scoped-packages-generate-master branch October 16, 2019 21:45

This was referenced Oct 17, 2019

docs(dev-workflow): Added steps for developing pure JS apps with {N} source code #7957

Closed

Developer workflow broken when linking plain JS app with NativeScript/tns-core-modules #7942

Closed

manoldonev mentioned this pull request Oct 22, 2019

refactor: deprecated topmost() usage NativeScript/nativescript-angular#2029

Merged

Uh oh!

feat: Scoped Packages #7911

feat: Scoped Packages #7911

Uh oh!

Conversation

vakrilov commented Oct 7, 2019

PR Checklist

Uh oh!

SvetoslavTsenov commented Oct 7, 2019

Uh oh!

SvetoslavTsenov commented Oct 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SvetoslavTsenov commented Oct 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SvetoslavTsenov commented Oct 15, 2019

Uh oh!

SvetoslavTsenov commented Oct 15, 2019

Uh oh!

vakrilov commented Oct 15, 2019

Uh oh!

vakrilov commented Oct 16, 2019

Uh oh!

SvetoslavTsenov commented Oct 16, 2019

Uh oh!

vakrilov commented Oct 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants