Fix the typing indicator when a player is acting #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some conditions, a player in act doesn't allow the chat indicator to be displayed correctly.
TovarischPootis
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of the plugin, some acts performed by players do not display the typing indicator correctly.
This issue can be tested with a large majority of acts in citizens but also in Civil Protection units. Acting will cause the
GetMoveTypefunction to return MOVETYPE_NONE meaning that the player is immobile or dead. Also theutil.TraceLinefunction with the current settings as well as those I have tested gives false negatives especially with /actsit.This fix is intended to address this issue without having any undesirable effects on the way it worked before. It has been tested for days on a server with no unwanted effects, but I'm still listening if you have a better way to fix this problem.