Fix the display of some parameter values in server configuration panel #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Spaces before/after operators - Remove useless argument in "cfgSet" notification - Reduction of pyramid scopes - Replace C operators to Lua ones (My linter is still not happy, but the number of issues has already been reduced a lot compared to the original copy. The code should probably be redesigned in the future)
Before this change, only the parameters without an explicit form had their current value and not the one defined by default. Now this annoying problem is fixed.
Contributor
|
Can you show some before/after screenshots to show what was fixed in the UI? |
Contributor
Author
|
I made a video to show before and after the fix: https://youtu.be/oMqjs9U_-y4. If you need more details, let me know. |
Contributor
|
Tres bien |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's all in the title. Adding the fact the code has been cleaned up to avoid formatting problems for linters.
This change is currently being tested but does not present a bug at the moment. So for the moment I'm keeping it in draft.