grass.jupyter: add test for utils.py functions#7070
Open
ayushjariyal wants to merge 5 commits intoOSGeo:mainfrom
Open
grass.jupyter: add test for utils.py functions#7070ayushjariyal wants to merge 5 commits intoOSGeo:mainfrom
ayushjariyal wants to merge 5 commits intoOSGeo:mainfrom
Conversation
Contributor
Author
|
@gulshan-123, thanks for the suggestion. I’ve updated the code accordingly in this PR and and verified it locally by running pytest from a normal Linux terminal(Not from inside GRASS teminal and not from inside docker container). All tests are now passing. 
Can you please review this? |
Contributor
Author
|
@petrasovaa , The CI is currently failing due to lint errors in super linters. I verify it locally and everything pass successfully on my system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add tests for
get_regionandget_location_proj_string.In this PR I initialize GRASS session using existing fixtures and avoid relying of GRASS environment to ensure they run correctly outside GRASS shell and CI.
Tests were verify locally in clean Docker image outside GRASS shell.