Added JAXB Codec by gregwhitaker · Pull Request #115 · OpenFeign/feign

gregwhitaker · 2014-07-16T19:04:17Z

Added module for encoding and decoding using JAXB.

cloudbees-pull-request-builder · 2014-07-16T19:29:16Z

feign-pull-requests #156 SUCCESS
This pull request looks good

cloudbees-pull-request-builder · 2014-07-16T21:24:24Z

feign-pull-requests #157 SUCCESS
This pull request looks good

codefromthecrypt · 2014-07-16T21:49:18Z

jaxb/src/main/java/feign/jaxb/JAXBContextFactory.java

Removed * import

codefromthecrypt · 2014-07-16T21:56:54Z

Thanks. This is really helpful. Looks good after comments are addressed. Don't forget to update CHANGES

Removed a stray System.out Modified CHANGES.md

cloudbees-pull-request-builder · 2014-07-16T22:23:35Z

feign-pull-requests #158 SUCCESS
This pull request looks good

Refactored JAXBContextFactory to use a builder for creation Added more tests

cloudbees-pull-request-builder · 2014-07-16T23:55:55Z

feign-pull-requests #159 FAILURE
Looks like there's a problem with this pull request

cloudbees-pull-request-builder · 2014-07-17T00:27:40Z

feign-pull-requests #160 SUCCESS
This pull request looks good

gregwhitaker · 2014-07-17T00:29:09Z

I fixed the issues in the comments. Let me know what you think. Thanks!

cloudbees-pull-request-builder · 2014-07-17T15:34:15Z

feign-pull-requests #161 FAILURE
Looks like there's a problem with this pull request

cloudbees-pull-request-builder · 2014-07-17T15:38:20Z

feign-pull-requests #162 FAILURE
Looks like there's a problem with this pull request

cloudbees-pull-request-builder · 2014-07-17T15:39:12Z

feign-pull-requests #163 FAILURE
Looks like there's a problem with this pull request

codefromthecrypt · 2014-07-17T16:43:08Z

jaxb/src/main/java/feign/jaxb/JAXBModule.java

nit: let's make the provides methods package private

codefromthecrypt · 2014-07-17T16:51:04Z

looks good. I see why you wanted the factory. Make sure it has a test case, then squash for a merge. good work.

Refactored encoder() and decoder() methods in JAXBModule so they are package private

commit f681d05 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Thu Jul 17 15:32:18 2014 -0700 Refactored JAXBModule, JAXBEncoder, JAXBDecoder commit bf67821 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Thu Jul 17 10:48:28 2014 -0700 Added unit tests for JAXBContextFactoryTest Refactored encoder() and decoder() methods in JAXBModule so they are package private commit 14e623b Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Thu Jul 17 08:36:44 2014 -0700 Modified JAXB readme so that the example hosts are not real domains commit ccb5321 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Thu Jul 17 08:36:05 2014 -0700 Modified JAXB readme so that the example hosts are not real domains commit c763247 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Thu Jul 17 08:31:01 2014 -0700 Added JAXB module to Feign README commit 04efe8b Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 16:59:29 2014 -0700 Modified README to reflect changes in JAXBContextFactory commit 65b1906 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 16:53:22 2014 -0700 Refactored JAXBModule per Adrian's comments Refactored JAXBContextFactory to use a builder for creation Added more tests commit 6baa072 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 15:04:21 2014 -0700 Added license to all files Removed a stray System.out Modified CHANGES.md commit 2c6f3b8 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 14:56:42 2014 -0700 Fixed copyright date Removed * import commit aea5243 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 13:57:40 2014 -0700 Fixed Intellij's import * obsession commit 2ee2bb4 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 11:57:37 2014 -0700 Fixed PMD violation. commit 6aa00d5 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 10:52:16 2014 -0700 Added documentation for JAXB module. commit 433f376 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 10:48:24 2014 -0700 Added documentation for JAXB module. commit b71a5b5 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 10:45:56 2014 -0700 Added documentation for JAXB module. commit 02e11fd Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 10:42:13 2014 -0700 Added documentation for JAXB module. commit e1aabd7 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Wed Jul 16 10:34:11 2014 -0700 Added tests for JAXB module commit 1ea5df9 Author: Whitaker, Greg <Greg.Whitaker@nike.com> Date: Tue Jul 15 16:38:01 2014 -0700 Added module that supports JAXB

Merge branch master into squashed commit

cloudbees-pull-request-builder · 2014-07-18T00:28:53Z

feign-pull-requests #164 SUCCESS
This pull request looks good

cloudbees-pull-request-builder · 2014-07-18T00:51:34Z

feign-pull-requests #165 SUCCESS
This pull request looks good

cloudbees-pull-request-builder · 2014-07-18T06:54:34Z

feign-pull-requests #166 SUCCESS
This pull request looks good

cloudbees-pull-request-builder · 2014-07-18T07:21:08Z

feign-pull-requests #167 SUCCESS
This pull request looks good

gregwhitaker added 7 commits July 15, 2014 16:38

Added module that supports JAXB

1ea5df9

Added tests for JAXB module

e1aabd7

Added documentation for JAXB module.

02e11fd

Added documentation for JAXB module.

b71a5b5

Added documentation for JAXB module.

433f376

Added documentation for JAXB module.

6aa00d5

Fixed PMD violation.

2ee2bb4

Fixed Intellij's import * obsession

aea5243

codefromthecrypt reviewed Jul 16, 2014
View reviewed changes

jaxb/src/main/java/feign/jaxb/JAXBContextFactory.java Outdated

Copy link
Copy Markdown

Contributor

codefromthecrypt Jul 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit 2014

Fixed copyright date

2c6f3b8

Removed * import

Added license to all files

6baa072

Removed a stray System.out Modified CHANGES.md

Refactored JAXBModule per Adrian's comments

65b1906

Refactored JAXBContextFactory to use a builder for creation Added more tests

Modified README to reflect changes in JAXBContextFactory

04efe8b

Added JAXB module to Feign README

c763247

gregwhitaker added 2 commits July 17, 2014 08:36

Modified JAXB readme so that the example hosts are not real domains

ccb5321

Modified JAXB readme so that the example hosts are not real domains

14e623b

codefromthecrypt reviewed Jul 17, 2014
View reviewed changes

jaxb/src/main/java/feign/jaxb/JAXBModule.java Outdated

Copy link
Copy Markdown

Contributor

codefromthecrypt Jul 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's make the provides methods package private

gregwhitaker added 4 commits July 17, 2014 10:48

Added unit tests for JAXBContextFactoryTest

bf67821

Refactored encoder() and decoder() methods in JAXBModule so they are package private

Refactored JAXBModule, JAXBEncoder, JAXBDecoder

f681d05

Merge branch 'master' of https://github.com/gregwhitaker/feign

c01f55a

Merge branch master into squashed commit

gregwhitaker closed this Jul 18, 2014

gregwhitaker reopened this Jul 18, 2014

gregwhitaker closed this Jul 18, 2014

gregwhitaker reopened this Jul 18, 2014

gregwhitaker closed this Jul 18, 2014

OlgaMaciaszek mentioned this pull request May 11, 2023

feignclient transitive dependency vulnerability issue apache commons fileupload 1.4 in gradle #1975

Open

Conversation

gregwhitaker commented Jul 16, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 16, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 16, 2014

Uh oh!

codefromthecrypt Jul 16, 2014

Choose a reason for hiding this comment

Uh oh!

codefromthecrypt commented Jul 16, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 16, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 16, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 17, 2014

Uh oh!

gregwhitaker commented Jul 17, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 17, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 17, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 17, 2014

Uh oh!

codefromthecrypt Jul 17, 2014

Choose a reason for hiding this comment

Uh oh!

codefromthecrypt commented Jul 17, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 18, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 18, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 18, 2014

Uh oh!

cloudbees-pull-request-builder commented Jul 18, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants