Skip to content

Allows query parameters to match on a substring. Ex q=body:{body}#428

Merged
spencergibb merged 1 commit intomasterfrom
query-substring
Aug 5, 2016
Merged

Allows query parameters to match on a substring. Ex q=body:{body}#428
spencergibb merged 1 commit intomasterfrom
query-substring

Conversation

@codefromthecrypt
Copy link
Copy Markdown
Contributor

@codefromthecrypt codefromthecrypt commented Aug 4, 2016

This is to help develop apis like Elasticsearch which nest queries in
query parameters.

Fixes #424

Allows query parameters to match on a substring. Ex q=body:{body}
9254b8f 
This is to help develop apis like Elasticsearch which nest queries in
query parameters.

Fixes #424
@codefromthecrypt codefromthecrypt mentioned this pull request Aug 4, 2016
Closed
@spencergibb
Copy link
Copy Markdown
Contributor

spencergibb commented Aug 4, 2016

👍

@codefromthecrypt
Copy link
Copy Markdown
Contributor Author

codefromthecrypt commented Aug 4, 2016 via email

@jaylucas
Copy link
Copy Markdown

jaylucas commented Aug 5, 2016

Woooo 👍

@spencergibb spencergibb merged commit f350c65 into master Aug 5, 2016
@codefromthecrypt
Copy link
Copy Markdown
Contributor Author

codefromthecrypt commented Aug 5, 2016 via email

@spencergibb
Copy link
Copy Markdown
Contributor

spencergibb commented Aug 5, 2016

I will try it in a bit.

@spencergibb
Copy link
Copy Markdown
Contributor

spencergibb commented Aug 8, 2016

@adriancole done https://github.com/OpenFeign/feign/tree/release-9.1.0

@bgdennis
Copy link
Copy Markdown

bgdennis commented Nov 12, 2017

I wanted to try using Netflix Feign client for Elastic Search nested queries, I tried with single input and works fine , in my case I wanted to send a nested bool condition through Feign and the result throws me
"type": "search_phase_execution_exception",
"reason": "all shards failed",
"phase": "query",
"grouped": true,
"caused_by": {
"type": "parse_exception",
"reason": "Cannot parse 'body:{\n "query" : {\n "bool" : {\n "must" :[ {\n "terms" : {\n "name.key" : [97 ]\n }\n },\n {\n \t\t"term" : {"promotingCountries.key" : 234}\n }\n ]\n }\n}\n}': Encountered " <RANGE_GOOP> ": "" at line 1, column 17.\nWas expecting:\n "TO" ...\n ",
"caused_by": {
"type": "parse_exception",
"reason": "Encountered " <RANGE_GOOP> ": "" at line 1, column 17.\nWas expecting:\n "TO" ...\n "
}
}

@bgdennis
Copy link
Copy Markdown

bgdennis commented Nov 12, 2017

Does Feign Rest client be used for elastic search nested queires ? Any help on this

@velo velo deleted the query-substring branch May 5, 2018 22:31
velo pushed a commit that referenced this pull request Oct 7, 2024
@adriancole @spencergibb
Allows query parameters to match on a substring. Ex q=body:{body} (#428)
625d4f5 
This is to help develop apis like Elasticsearch which nest queries in
query parameters.

Fixes #424
velo pushed a commit that referenced this pull request Oct 8, 2024
@adriancole @spencergibb
Allows query parameters to match on a substring. Ex q=body:{body} (#428)
846d11e 
This is to help develop apis like Elasticsearch which nest queries in
query parameters.

Fixes #424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codefromthecrypt @spencergibb @jaylucas @bgdennis