Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Oct 10, 2019

PR Summary

#8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called Length and if so then formatting simply used ToString() which is undesired in this case. This is a very specific case where it is an object that contains only a member called Length. Searching the codebase, it appears SourceLength isn't actually used, so the fix is to remove this property and the check for it.

PR Context

Fix #10762

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 11, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 11, 2019
@iSazonov iSazonov changed the title remove unused SourceLength remoting property causing formatting issues Remove unused SourceLength remoting property causing formatting issues Oct 11, 2019
@iSazonov
Copy link
Collaborator

No problems with Windows PowerShell remoting compatibility?
Should we have tests for using the remoting constants?

@SteveL-MSFT
Copy link
Member Author

@iSazonov looked in the Windows PowerShell code base and this property isn't used either

@iSazonov iSazonov merged commit bf59561 into PowerShell:master Oct 12, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the length-property branch June 6, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select-Object default output formatting is situationally broken

3 participants