Skip to content

Impl PySequence Protocol #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 46 commits into from
Mar 12, 2022
Merged

Impl PySequence Protocol #3316

youknowone merged 46 commits into from
Mar 12, 2022

Conversation

@qingshi163
Copy link
Contributor

@qingshi163 qingshi163 commented Oct 15, 2021 •
edited by youknowone
Loading

@DimitrisJim DimitrisJim mentioned this pull request Oct 16, 2021
Merged
@DimitrisJim
Copy link
Member

DimitrisJim commented Oct 16, 2021 •
edited
Loading

Mentioning here so it isn't forgotten, ItemProtocol for PyObjectRef should be amended (maybe after #3306?) to also try the sequence protocol after the mapping one (and before trying to grab __getitem__).

youknowone
youknowone reviewed Oct 16, 2021
View reviewed changes
vm/src/protocol/sequence.rs

// Sequence Protocol
// https://docs.python.org/3/c-api/sequence.html

Copy link
Member

@youknowone youknowone Oct 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[allow(type_complexity)]

Those types are one-time use types.

@youknowone
Copy link
Member

youknowone commented Oct 16, 2021

I want to request @Snowapril 's review later. He must have been reviewed those mapping/sequence details when he implemented PyMapping

DimitrisJim
DimitrisJim reviewed Oct 16, 2021
View reviewed changes
@youknowone youknowone marked this pull request as draft October 16, 2021 07:24
@youknowone
Copy link
Member

youknowone commented Oct 16, 2021

@DimitrisJim I think processing #3306 as it is and work on ItemProtocol after this PR would be simpler.

@DimitrisJim
Copy link
Member

DimitrisJim commented Oct 16, 2021

sounds good to me

@qingshi163 qingshi163 force-pushed the sequence-protocol branch 2 times, most recently from 944eb0d to baeca0a Compare October 17, 2021 09:21
@zetwhite zetwhite mentioned this pull request Oct 24, 2021
Merged
@Snowapril Snowapril mentioned this pull request Nov 15, 2021
Merged
@qingshi163 qingshi163 mentioned this pull request Nov 19, 2021
Merged
@qingshi163 qingshi163 mentioned this pull request Nov 27, 2021
Merged
@qingshi163 qingshi163 changed the title [WIP] Impl PySequence Protocol Impl PySequence Protocol Dec 7, 2021
@qingshi163 qingshi163 marked this pull request as ready for review December 7, 2021 17:55
@qingshi163 qingshi163 requested a review from youknowone December 7, 2021 17:55
@qingshi163
Copy link
Contributor Author

qingshi163 commented Dec 20, 2021

@youknowone will you review this pr?

@Snowapril
Copy link
Contributor

Snowapril commented Mar 12, 2022

@qingshi163 Hello. Could I ask you is there any progress here?
Does only reviewing required for more progress?

@youknowone
Copy link
Member

youknowone commented Mar 12, 2022

I am sorry, I wasn't aware of pending reveiw request

qingshi163 added 23 commits March 12, 2022 16:12
@qingshi163 @youknowone
impl sequence protocol for dict_items dict_values dict_keys
83ae4b1
@qingshi163 @youknowone
refactor sliceable incomplete sequence protocol for list
b4907f0
@qingshi163 @youknowone
refactor PySliceableSequence -> SlicableSequenceOp
4be3c4f
@qingshi163 @youknowone
refactor BufferResizeGuard
01a8e01
@qingshi163 @youknowone
refactor use SliceableSequence for array
e3247da
@qingshi163 @youknowone
fix rebase
6b17fa1
@qingshi163 @youknowone
impl sequence protocol for PyRange
29e0831
@qingshi163 @youknowone
impl sequence protocol for PySet
f18b8f1
@qingshi163 @youknowone
impl sequence protocol for PyFrozenSet
0545e6a
@qingshi163 @youknowone
impl sequence protocol for PyTuple
1536dd9
@qingshi163 @youknowone
impl sequence protocol for PyStr
066ba2f
@qingshi163 @youknowone
impl sequence protocol for PyDeque
0c9235c
@qingshi163 @youknowone
fix rebase
b91ec26
@qingshi163 @youknowone
mark fail tests
10020a9
@qingshi163 @youknowone
fix fmt
994c0be
@qingshi163 @youknowone
move obj_as to sequence_downcast
0abe90d
@qingshi163 @youknowone
fix item protocol use sequence protocol
c6ee563
@qingshi163 @youknowone
fix hang on __index__
7b8c409
@qingshi163 @youknowone
fix bytes getitem return type
a2d71e7
@qingshi163 @youknowone
fix sliceable return index error instead overflow error
8cdbd18
@qingshi163 @youknowone
fix range raise overflow error for isize
9d443bb
@qingshi163 @youknowone
fix bytearray delitem not raise buffer error
a3655d3
@qingshi163 @youknowone
unmark passed test
d962fd9
@youknowone
Copy link
Member

youknowone commented Mar 12, 2022

@qingshi163 I rebased it to merge, sorry for late review

@youknowone youknowone merged commit def4a2b into RustPython:main Mar 12, 2022
@qingshi163 qingshi163 deleted the sequence-protocol branch May 11, 2022 17:22
@youknowone youknowone mentioned this pull request May 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DimitrisJim DimitrisJim DimitrisJim left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qingshi163 @DimitrisJim @youknowone @Snowapril