Skip to content

Implement AsMapping for PyStr #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Nov 6, 2021
Merged

Implement AsMapping for PyStr #3417

youknowone merged 1 commit into from
Nov 6, 2021

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Nov 6, 2021 •
edited
Loading

This pull request tries to resolve the part of #3244.

Mapping trait to provide type slot as_mapping

P.S. maybe it should be AsMapping trait 🤔

@moreal moreal marked this pull request as ready for review November 6, 2021 07:27
@youknowone
Copy link
Member

youknowone commented Nov 6, 2021

@Snowapril could you review this PR?

Snowapril
Snowapril approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@Snowapril Snowapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊

@youknowone youknowone merged commit 820a67c into RustPython:main Nov 6, 2021
@youknowone youknowone mentioned this pull request Nov 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

+1 more reviewer

@Snowapril Snowapril Snowapril approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moreal @youknowone @Snowapril