Add count.reduce() #3737
Merged
Add count.reduce() #3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
are there related tests in |
Contributor
|
27 tasks
youknowone
requested changes
May 22, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
This is not compatible to pickle
youknowone
requested changes
May 22, 2022
vm/src/stdlib/itertools.rs
Outdated
| Ok(*times.read()) | ||
| } | ||
|
|
||
|
|
vm/src/stdlib/itertools.rs
Outdated
| #[pyimpl(with(IterNext, Constructor))] | ||
| impl PyItertoolsCount {} | ||
| impl PyItertoolsCount { | ||
|
|
youknowone
approved these changes
May 22, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
thank you for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3611