Skip to content

Add NotImplemented.__reduce__() #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from May 22, 2022
Merged

Add NotImplemented.__reduce__() #3738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1433d87
Add NotImplemted.reduce()
May 22, 2022
e5816a4
delete expectedFailture
May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Lib/test/test_pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
super().test_newobj_proxies() # TODO: RUSTPYTHON, remove when this passes

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
super().test_notimplemented() # TODO: RUSTPYTHON, remove when this passes

Expand Down Expand Up @@ -165,8 +163,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
super().test_recursive_nested_names() # TODO: RUSTPYTHON, remove when this passes

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
super().test_singleton_types() # TODO: RUSTPYTHON, remove when this passes

Expand Down Expand Up @@ -251,8 +247,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
super().test_newobj_proxies() # TODO: RUSTPYTHON, remove when this passes

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
super().test_notimplemented() # TODO: RUSTPYTHON, remove when this passes

Expand Down Expand Up @@ -286,8 +280,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
super().test_recursive_nested_names() # TODO: RUSTPYTHON, remove when this passes

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
super().test_singleton_types() # TODO: RUSTPYTHON, remove when this passes

Expand Down
4 changes: 0 additions & 4 deletions Lib/test/test_pickletools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
super().test_newobj_proxies()

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
super().test_notimplemented()

Expand Down Expand Up @@ -87,8 +85,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
super().test_recursive_nested_names()

# TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
@unittest.expectedFailure
def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
super().test_singleton_types()

Expand Down
5 changes: 5 additions & 0 deletions vm/src/builtins/singletons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ impl PyNotImplemented {
fn repr(&self) -> String {
"NotImplemented".to_owned()
}

#[pymethod(magic)]
fn reduce(&self) -> String {
"NotImplemented".to_owned()
}
}

pub fn init(context: &Context) {
Expand Down