Skip to content

Implement number protocol for PyBytes #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 6 commits into from
Jul 19, 2022
Merged

Implement number protocol for PyBytes #3903

youknowone merged 6 commits into from
Jul 19, 2022

Conversation

@Karatuss
Copy link
Contributor

@Karatuss Karatuss commented Jul 16, 2022 •
edited
Loading

resolved: #3883

@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 16, 2022
Snowapril
Snowapril reviewed Jul 16, 2022
View reviewed changes
@Karatuss @Snowapril
Update vm/src/builtins/bytes.rs
c0aae15 
Co-authored-by: Snowapril <sinjihng@gmail.com>
youknowone
youknowone reviewed Jul 16, 2022
View reviewed changes
@fanninpm fanninpm requested a review from qingshi163 July 16, 2022 13:57
youknowone
youknowone requested changes Jul 18, 2022
View reviewed changes
youknowone
youknowone requested changes Jul 18, 2022
View reviewed changes
@fanninpm
Copy link
Contributor

fanninpm commented Jul 18, 2022

The unexpected success in test_dict is due to something unrelated to your PR. It's fixed in main, so feel free to rebase.

@youknowone
Copy link
Member

youknowone commented Jul 18, 2022

The commit history looking weird.
while upstream is RustPython/RustPython, please try git rebase -i upstream/main and remove commits you didn't directly authored.

youknowone
youknowone approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@youknowone youknowone merged commit 463b516 into RustPython:main Jul 19, 2022
@Karatuss Karatuss deleted the impl-nb-bytes branch July 20, 2022 10:18
@youknowone youknowone mentioned this pull request Jul 24, 2022
Open
@fanninpm fanninpm mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@qingshi163 qingshi163 Awaiting requested review from qingshi163

+1 more reviewer

@Snowapril Snowapril Snowapril left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Number Protocol for PyBytes

4 participants

@Karatuss @fanninpm @youknowone @Snowapril