Skip to content

Conversation

@youknowone
Copy link
Member

requested by @fanninpm

#3910 (comment)

@youknowone youknowone requested a review from fanninpm July 18, 2022 13:18
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be careful with merge conflicts, but otherwise LGTM.

@fanninpm
Copy link
Contributor

That test_views_mapping unexpected success is likely a fluke.

@youknowone
Copy link
Member Author

that was an invisible conflict to #3898

@youknowone youknowone merged commit 9878d72 into RustPython:main Jul 18, 2022
@youknowone youknowone deleted the fix-userlist branch July 18, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants