Skip to content

Conversation

@lgyanf
Copy link
Contributor

@lgyanf lgyanf commented Jan 9, 2023

Add accumulate.reduce implementation for #3611.

Publishing as a draft to collect initial feedback. Behaviour seems to be identical to CPython's, but I'm still testing.

Relevant links

@fanninpm
Copy link
Contributor

fanninpm commented Jan 9, 2023

Is this related to #3611?

@youknowone
Copy link
Member

Because you fixed related bug from the test suites, you can remove @unittest.expectedFailure decorator from test_accumulate_reducible test

@fanninpm
Copy link
Contributor

cc @Snowapril

@DimitrisJim DimitrisJim force-pushed the accumulate-reduce branch 2 times, most recently from 0de70f9 to e918d56 Compare May 19, 2023 15:32
@DimitrisJim DimitrisJim marked this pull request as ready for review May 19, 2023 19:44
@youknowone youknowone merged commit cbaed46 into RustPython:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants