Skip to content

Implement Number Protocol for PyByteArray #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Feb 25, 2023
Merged

Implement Number Protocol for PyByteArray #4574

youknowone merged 1 commit into from
Feb 25, 2023

Conversation

@xiaozhiyan
Copy link
Contributor

@xiaozhiyan xiaozhiyan commented Feb 25, 2023

Closes #4573

@youknowone youknowone mentioned this pull request Feb 25, 2023
Open
youknowone
youknowone approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@youknowone youknowone merged commit 204643b into RustPython:main Feb 25, 2023
@youknowone youknowone added the z-ls-2023 Tag to track Line OSS Sprint 2023 label Feb 25, 2023
@xiaozhiyan xiaozhiyan deleted the implement-number-protocol-for-pybytearray branch February 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@qingshi163 qingshi163 Awaiting requested review from qingshi163

Assignees

No one assigned

Labels

z-ls-2023 Tag to track Line OSS Sprint 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Number Protocol for PyByteArray

2 participants

@xiaozhiyan @youknowone