Skip to content

Implemented __reduce__ method for types.SimpleNamespace #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
May 17, 2023
Merged

Implemented __reduce__ method for types.SimpleNamespace #4975

youknowone merged 2 commits into from
May 17, 2023

Conversation

@LucaSforza
Copy link
Contributor

@LucaSforza LucaSforza commented May 15, 2023

Added __reduce__ method for types.SimpleNamespace #3611.

@fanninpm
Copy link
Contributor

fanninpm commented May 15, 2023

cc @Snowapril

@youknowone
Copy link
Member

youknowone commented May 15, 2023

Congratulation! You fixed a test test.test_types.SimpleNamespaceTests.test_pickle
Could you remove expectedFailure decorator and # TODO comment from the test?

@DimitrisJim DimitrisJim mentioned this pull request May 15, 2023
Closed
27 tasks
youknowone
youknowone approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit a1d9c64 into RustPython:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LucaSforza @fanninpm @youknowone