Skip to content

Move compiler-core -> crates/compiler-core #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Nov 14, 2025
Merged

Move compiler-core -> crates/compiler-core #6258

youknowone merged 1 commit into from
Nov 14, 2025
+1 −2

Conversation

@ShaharNaveh
Copy link
Collaborator

@ShaharNaveh ShaharNaveh commented Nov 14, 2025 •
edited by coderabbitai bot
Loading

ref: #6214

Summary by CodeRabbit

  • Chores
    • Internal project structure reorganization to improve maintainability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025 •
edited
Loading

Walkthrough

The workspace reorganizes the compiler-core crate location from compiler/core to crates/compiler-core. The workspace members list is updated to reflect this structural change, and the dependency path is adjusted accordingly.

Changes

Cohort / File(s) Summary
Workspace restructuring
Cargo.toml		 Removed "compiler/core" from workspace members; updated "rustpython-compiler-core" dependency path from "compiler/core" to "crates/compiler-core"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A crate hops from compiler/core to crates so neat,
Path adjustments make the workspace complete,
From old to new, the references align,
One little shuffle—everything's fine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the compiler-core directory from its current location to the crates/compiler-core path, which is reflected in both the Cargo.toml path update and workspace restructuring.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and 317cfcb.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-28T22:22:55.921Z 
Learnt from: reactive-firewall
Repo: RustPython/RustPython PR: 6176
File: .github/workflows/Check_Tests.yml:133-141
Timestamp: 2025-09-28T22:22:55.921Z
Learning: In the RustPython project's CI-5974-Test-RustPython-Integration action, the override-rustpython-path input is marked as required but has runtime fallback logic that defaults to RUSTPYTHONPATH environment variable or "Lib" if neither is provided, making explicit specification unnecessary in most cases.

Applied to files:

  • Cargo.toml
🔇 Additional comments (1)
Cargo.toml (1)

150-150: I need to verify the version match and check for any remaining references to the old path. Let me run an additional verification script:

No issues found with the crate relocation.

The migration from compiler/core to crates/compiler-core has been successfully completed. Verification confirms:

  • The glob pattern "crates/*" matches and includes the new crate location
  • The crates/compiler-core/Cargo.toml exists with the correct package name rustpython-compiler-core
  • No stale references to the old path remain in the codebase
  • The downstream dependency in compiler/Cargo.toml correctly uses workspace inheritance ({ workspace = true }), which resolves through the root Cargo.toml path update

The path update on line 150 and workspace configuration are correct and consistent.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 14, 2025
Open
16 tasks
@fanninpm
Copy link
Contributor

fanninpm commented Nov 14, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@youknowone youknowone merged commit bb54c5b into RustPython:main Nov 14, 2025
13 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @fanninpm @youknowone