Skip to content

Faulthandler #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Dec 11, 2025
Merged

Faulthandler #6400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b376dea
impl faulthandler
youknowone Dec 11, 2025
f9f8427
faulthandler
youknowone Dec 11, 2025
7ee0118
string
youknowone Dec 11, 2025
0a2b2ba
fix faulthandler on macos
youknowone Dec 11, 2025
97943dc
fix watchdog
youknowone Dec 11, 2025
8a9096a
install handler
youknowone Dec 11, 2025
96f44ac
Apply review based on cpython
youknowone Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions Lib/test/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,6 @@ def test_dump_ext_modules(self):
for name in ('sys', 'faulthandler'):
self.assertIn(name, modules)

# TODO: RUSTPYTHON, AttributeError: module 'faulthandler' has no attribute 'is_enabled'
@unittest.expectedFailure
def test_is_enabled(self):
orig_stderr = sys.stderr
try:
Expand All @@ -435,8 +433,6 @@ def test_is_enabled(self):
finally:
sys.stderr = orig_stderr

# TODO: RUSTPYTHON, subprocess.CalledProcessError: Command ... returned non-zero exit status 1.
@unittest.expectedFailure
@support.requires_subprocess()
def test_disabled_by_default(self):
# By default, the module should be disabled
Expand Down Expand Up @@ -528,12 +524,10 @@ def funcA():
self.assertEqual(trace, expected)
self.assertEqual(exitcode, 0)

# TODO: RUSTPYTHON, AssertionError: Lists differ
@unittest.expectedFailure
def test_dump_traceback(self):
self.check_dump_traceback()

# TODO: RUSTPYTHON
# TODO: RUSTPYTHON - binary file write needs different handling
@unittest.expectedFailure
def test_dump_traceback_file(self):
with temporary_filename() as filename:
Expand All @@ -547,8 +541,6 @@ def test_dump_traceback_fd(self):
with tempfile.TemporaryFile('wb+') as fp:
self.check_dump_traceback(fd=fp.fileno())

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_truncate(self):
maxlen = 500
func_name = 'x' * (maxlen + 50)
Expand Down Expand Up @@ -870,8 +862,6 @@ def check_stderr_none(self):
finally:
sys.stderr = stderr

# TODO: RUSTPYTHON, AssertionError: RuntimeError not raised
@unittest.expectedFailure
def test_stderr_None(self):
# Issue #21497: provide a helpful error if sys.stderr is None,
# instead of just an attribute error: "None has no attribute fileno".
Expand Down Expand Up @@ -902,8 +892,6 @@ def test_raise_exception(self):
3,
name)

# TODO: RUSTPYTHON, AttributeError: module 'msvcrt' has no attribute 'GetErrorMode'
@unittest.expectedFailure
@unittest.skipUnless(MS_WINDOWS, 'specific to Windows')
def test_ignore_exception(self):
for exc_code in (
Expand All @@ -920,8 +908,6 @@ def test_ignore_exception(self):
self.assertEqual(output, [])
self.assertEqual(exitcode, exc_code)

# TODO: RUSTPYTHON, AttributeError: module 'msvcrt' has no attribute 'GetErrorMode'
@unittest.expectedFailure
@unittest.skipUnless(MS_WINDOWS, 'specific to Windows')
def test_raise_nonfatal_exception(self):
# These exceptions are not strictly errors. Letting
Expand Down Expand Up @@ -950,8 +936,6 @@ def test_raise_nonfatal_exception(self):
self.assertIn(exitcode,
(exc, exc & ~0x10000000))

# TODO: RUSTPYTHON, AttributeError: module 'msvcrt' has no attribute 'GetErrorMode'
@unittest.expectedFailure
@unittest.skipUnless(MS_WINDOWS, 'specific to Windows')
def test_disable_windows_exc_handler(self):
code = dedent("""
Expand All @@ -965,8 +949,6 @@ def test_disable_windows_exc_handler(self):
self.assertEqual(output, [])
self.assertEqual(exitcode, 0xC0000005)

# TODO: RUSTPYTHON, AssertionError: Lists differ
@unittest.expectedFailure
def test_cancel_later_without_dump_traceback_later(self):
# bpo-37933: Calling cancel_dump_traceback_later()
# without dump_traceback_later() must not segfault.
Expand All @@ -978,7 +960,6 @@ def test_cancel_later_without_dump_traceback_later(self):
self.assertEqual(output, [])
self.assertEqual(exitcode, 0)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON; AttributeError: module 'msvcrt' has no attribute 'GetErrorMode'")
@threading_helper.requires_working_threading()
@unittest.skipUnless(support.Py_GIL_DISABLED, "only meaningful if the GIL is disabled")
def test_free_threaded_dump_traceback(self):
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,8 +1833,6 @@ def test_run_with_shell_timeout_and_capture_output(self):
msg="TimeoutExpired was delayed! Bad traceback:\n```\n"
f"{stacks}```")

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_encoding_warning(self):
code = textwrap.dedent("""\
from subprocess import *
Expand Down
1 change: 1 addition & 0 deletions crates/stdlib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ features = [
"Win32_NetworkManagement_Ndis",
"Win32_Security_Cryptography",
"Win32_Storage_FileSystem",
"Win32_System_Diagnostics_Debug",
"Win32_System_Environment",
"Win32_System_IO",
"Win32_System_Threading"
Expand Down
Loading
Loading