Skip to content

Exclude tests and ensurepip from default frozen stdlib #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Exclude tests and ensurepip from default frozen stdlib #6520

Copilot wants to merge 6 commits into from
+84 −10

Conversation

Copy link
Contributor

Copilot AI commented Dec 25, 2025 •
edited
Loading

  • Address clippy warnings in py_freeze exclude handling
  • Run targeted checks (cargo clippy -p rustpython-derive-impl -- -D warnings)
  • Default frozen stdlib excludes test/ensurepip per feature removal
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove Lib/test/ and Lib/ensurepip from freeze-stdlib</issue_title>
<issue_description>Let's remove Lib/test/ and Lib/ensurepip from freeze-stdlib as the default option.
It will be helpful to reduce frozen library size.

but also we need to add another option to enable it again to allow run test from wasm build</issue_description>

Comments on the Issue (you are @copilot in this section)

@youknowone This is mostly rust proc-macro work. It will be a sort of easy issue for people who used to write proc-macro code. Otherwise it might be quite confusing because proc-macro has its own ecosystem a little bit different from common rust code. I will recommend this issue for someone who want to have experience to edit proc-macro code.

Adding exclude to rustpython_derive::py_freeze! will be a good starting point.</comment_new>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025 •
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits December 25, 2025 10:39
@youknowone
Implement freeze stdlib excludes
77c3af9 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
@youknowone
Document py_freeze exclude handling
2864486 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove Lib/test and Lib/ensurepip from freeze-stdlib Exclude tests and ensurepip from default frozen stdlib; add opt-in full freeze Dec 25, 2025
Copilot AI requested a review from youknowone December 25, 2025 10:45
youknowone
youknowone requested changes Dec 25, 2025
View reviewed changes
crates/pylib/Cargo.toml Outdated

[features]
freeze-stdlib = ["dep:rustpython-compiler-core", "dep:rustpython-derive"]
freeze-stdlib-full = ["freeze-stdlib"]
Copy link
Member

@youknowone youknowone Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the default. we don't need this feature. blocklisted libs are useless

Copy link
Contributor Author

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented: removed the freeze-stdlib-full feature and kept the default frozen stdlib excluding Lib/test and Lib/ensurepip (commit 5a5733a).

@youknowone
Remove freeze-stdlib-full option
5a5733a 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Copilot AI changed the title Exclude tests and ensurepip from default frozen stdlib; add opt-in full freeze Exclude tests and ensurepip from default frozen stdlib Dec 25, 2025
Copilot AI requested a review from youknowone December 25, 2025 12:03
@youknowone youknowone marked this pull request as ready for review December 25, 2025 12:28
@youknowone
Copy link
Member

youknowone commented Dec 25, 2025

@copilot fix clippy warnings

@youknowone
Fix clippy warnings
01dc9e6 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 25, 2025

@copilot fix clippy warnings

Clippy warnings resolved in commit 01dc9e6 (collapsed nested check and reduced arguments via shared exclusion context).

youknowone
youknowone reviewed Dec 30, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@youknowone youknowone

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Lib/test/ and Lib/ensurepip from freeze-stdlib

2 participants

@youknowone