Skip to content

Conversation

@terryluan12
Copy link
Contributor

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)
  • Lib/enum.py is excluded by !Lib/**
  • Lib/filecmp.py is excluded by !Lib/**
  • Lib/test/test_ast/test_ast.py is excluded by !Lib/**
  • Lib/test/test_enum.py is excluded by !Lib/**
  • Lib/test/test_filecmp.py is excluded by !Lib/**
  • Lib/test/test_ssl.py is excluded by !Lib/**
  • Lib/test/test_uuid.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12
Copy link
Contributor Author

Sorry about the repeat PR. I tried to do some trickery with rebasing, but am just going to recommit on the main branch

@terryluan12
Copy link
Contributor Author

terryluan12 commented Dec 31, 2025

I think also for the sake of less spam, I'll do two-three libraries at a time (Let me know if I shouldn't, and instead should have individual PR's for each library)

@terryluan12 terryluan12 changed the title Updated enum library Updated enum + file_cmp library + tests Dec 31, 2025
@fanninpm fanninpm requested a review from ShaharNaveh December 31, 2025 04:43
@terryluan12
Copy link
Contributor Author

@ShaharNaveh there is one test that is failing locally, but succeeding in the CI testing (test.test_enum.OldTestIntFlag.test_global_enum_str). Can you check it on your side, and advise?

@terryluan12 terryluan12 changed the title Updated enum + file_cmp library + tests Updated enum + file_cmp library + tests - v3.13.10 Dec 31, 2025
@fanninpm
Copy link
Contributor

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features encodings,sqlite -- -m test -h.

@terryluan12
Copy link
Contributor Author

terryluan12 commented Dec 31, 2025

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features encodings,sqlite -- -m test -h.

Ah, thanks for the suggestion, will try the command you sent!

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!
you don't have to worry about spamming too much, but this way will be easier because tests are related to each others. In this PR, test_ssl and test_uuid is unexpectedly related to (probably) enum

@youknowone youknowone merged commit 52dd829 into RustPython:main Jan 2, 2026
13 checks passed
@terryluan12 terryluan12 deleted the update_enum branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants