-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Updated enum + file_cmp library + tests - v3.13.10 #6606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (7)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Sorry about the repeat PR. I tried to do some trickery with rebasing, but am just going to recommit on the main branch |
|
I think also for the sake of less spam, I'll do two-three libraries at a time (Let me know if I shouldn't, and instead should have individual PR's for each library) |
|
@ShaharNaveh there is one test that is failing locally, but succeeding in the CI testing ( |
|
I believe you can use the following command to test your changes locally: # this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features encodings,sqlite -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whateverFor a list of all resources and more command-line options, you can execute |
Ah, thanks for the suggestion, will try the command you sent! |
youknowone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you!
you don't have to worry about spamming too much, but this way will be easier because tests are related to each others. In this PR, test_ssl and test_uuid is unexpectedly related to (probably) enum
No description provided.