-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Updated token + weakref libraries + weakref test - v3.13.11 #6633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I could not find a token test file |
|
by searching |
I saw that, & assumed that it would test out the tokenize library, but as I'm writing it out I'm realizing I should probably jointly update the two libraries. Will add it, thanks! |
|
So it seems a rewrite of tokenize has been done. the _tokenize function was moved to a precompiled library, and logic has been changed, so it's not as simple as keeping the older _tokenize version. Is it okay to merge, without making any tokenization migrations? |
|
It's a bit of a different error, but waiting until #6635 is merged until debugging |
cd1bf05 to
c961277
Compare
youknowone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…on#6633) * Updated the token library * Updated the weakref library * Annotated the failing weakref test
…on#6633) * Updated the token library * Updated the weakref library * Annotated the failing weakref test
…on#6633) * Updated the token library * Updated the weakref library * Annotated the failing weakref test
No description provided.